Do not overwrite GORELEASER_CURRENT_TAG if already declared (#260)

Co-authored-by: CrazyMax <crazy-max@users.noreply.github.com>

.dockerignore

@@ -0,0 +1 @@
+node_modules

.github/workflows/ci.yml

@@ -3,14 +3,16 @@ name: ci
 on:
   schedule:
     - cron: '0 10 * * *' # everyday at 10am
-  pull_request:
-    branches:
-      - master
-      - releases/v*
   push:
     branches:
-      - master
+      - 'master'
-      - releases/v*
+      - 'releases/v*'
+    tags:
+      - 'v*'
+  pull_request:
+    branches:
+      - 'master'
+      - 'releases/v*'
 
 jobs:
   ci:
@@ -24,7 +26,7 @@ jobs:
           - windows-latest
         version:
           - latest
-          - v0.117.0
+          - v0.145.0
     steps:
       -
         name: Checkout
@@ -35,7 +37,7 @@ jobs:
         name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.14
+          go-version: 1.15
       -
         name: Check
         uses: ./
@@ -49,8 +51,39 @@ jobs:
           version: ${{ matrix.version }}
           args: release --skip-publish --rm-dist
 
+  install-only:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        version:
+          - latest
+          - v0.145.0
+    steps:
+      -
+        name: Checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      -
+        name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.15
+      -
+        name: GoReleaser
+        uses: ./
+        with:
+          version: ${{ matrix.version }}
+          install-only: true
+      -
+        name: Check
+        run: |
+          goreleaser check --debug
+
   signing:
     runs-on: ${{ matrix.os }}
+    if: github.event_name != 'pull_request'
     strategy:
       fail-fast: false
       matrix:
@@ -68,14 +101,14 @@ jobs:
         name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.14
+          go-version: 1.15
       -
         name: Import GPG key
         id: import_gpg
-        uses: crazy-max/ghaction-import-gpg@v2
+        uses: crazy-max/ghaction-import-gpg@v3
-        env:
+        with:
-          GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY_TEST }}
+          gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY_TEST }}
-          PASSPHRASE: ${{ secrets.PASSPHRASE_TEST }}
+          passphrase: ${{ secrets.PASSPHRASE_TEST }}
       -
         name: Check
         uses: ./
@@ -92,3 +125,33 @@ jobs:
           args: -f .goreleaser-signing.yml release --skip-publish --rm-dist
         env:
           GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }}
+
+  upload-artifact:
+    runs-on: ubuntu-latest
+    steps:
+      -
+        name: Checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      -
+        name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.15
+      -
+        name: Check
+        uses: ./
+        with:
+          args: check --debug
+      -
+        name: GoReleaser
+        uses: ./
+        with:
+          args: release --skip-publish --rm-dist
+      -
+        name: Upload assets
+        uses: actions/upload-artifact@v2
+        with:
+          name: myapp
+          path: dist/*

.github/workflows/pre-checkin.yml

@@ -1,30 +0,0 @@
-name: pre-checkin
-
-on:
-  push:
-    paths-ignore:
-      - '**.md'
-  pull_request:
-    paths-ignore:
-      - '**.md'
-
-jobs:
-  pre-checkin:
-    runs-on: ubuntu-latest
-    steps:
-      -
-        name: Checkout
-        uses: actions/checkout@v2
-      -
-        name: Install
-        run: yarn install
-      -
-        name: Pre-checkin
-        run: yarn run pre-checkin
-      -
-        name: Check for uncommitted changes
-        run: |
-          if [[ `git status --porcelain` ]]; then
-            git status --porcelain
-            echo "::warning::Found changes. Please run 'yarn run pre-checkin' and push"
-          fi

.github/workflows/test.yml

@@ -12,6 +12,21 @@ on:
       - '**.md'
 
 jobs:
+  test-containerized:
+    runs-on: ubuntu-latest
+    steps:
+      -
+        name: Checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      -
+        name: Validate
+        run: docker buildx bake validate
+      -
+        name: Test
+        run: docker buildx bake test
+
   test:
     runs-on: ${{ matrix.os }}
     strategy:
@@ -35,7 +50,7 @@ jobs:
         run: yarn run test
       -
         name: Upload coverage
-        uses: codecov/codecov-action@v1.0.7
+        uses: codecov/codecov-action@v1
         if: success()
         with:
           token: ${{ secrets.CODECOV_TOKEN }}

CHANGELOG.md

@@ -1,5 +1,34 @@
 # Changelog
 
+## 2.4.1 (2020/12/02)
+
+* Do not overwrite GORELEASER_CURRENT_TAG if already declared (#260)
+
+## 2.4.0 (2020/11/30)
+
+* Set GORELEASER_CURRENT_TAG (#259)
+* Container based developer flow (#258)
+* Upload artifact example (#257)
+* Bump @actions/tool-cache from 1.6.0 to 1.6.1 (#256)
+
+## 2.3.0 (2020/11/06)
+
+* Add install-only option for using goreleaser in user scripts (#252)
+* Update deps
+
+## 2.2.1 (2020/10/01)
+
+* Fix CVE-2020-15228
+
+## 2.2.0 (2020/08/27)
+
+* Use GITHUB_REF to retrieve tag before checking the most recent tag (#238)
+* Update deps
+
+## 2.1.1 (2020/06/24)
+
+* Fix workdir (#224)
+
 ## 2.1.0 (2020/06/15)
 
 * Implement (optional) semver parsing of version (#213)

Dockerfile.dev

@@ -0,0 +1,46 @@
+#syntax=docker/dockerfile:1.1-experimental
+
+FROM node:12 AS deps
+WORKDIR /src
+COPY package.json yarn.lock ./
+RUN --mount=type=cache,target=/usr/local/share/.cache/yarn \
+  yarn install
+
+FROM scratch AS update-yarn
+COPY --from=deps /src/yarn.lock /
+
+FROM deps AS validate-yarn
+COPY .git .git
+RUN status=$(git status --porcelain -- yarn.lock); if [ -n "$status" ]; then echo $status; exit 1; fi
+
+FROM deps AS base
+COPY . .
+
+FROM base AS build
+RUN yarn build
+
+FROM deps AS test
+ARG TARGETOS
+ARG TARGETARCH
+ENV RUNNER_TEMP=/tmp/github_runner
+ENV RUNNER_TOOL_CACHE=/tmp/github_tool_cache
+COPY . .
+RUN yarn run test
+
+FROM base AS run-format
+RUN yarn run format
+
+FROM scratch AS format
+COPY --from=run-format /src/src/*.ts /src/
+
+FROM base AS validate-format
+RUN yarn run format-check
+
+FROM scratch AS dist
+COPY --from=build /src/dist/ /dist/
+
+FROM build AS validate-build
+RUN status=$(git status --porcelain -- dist); if [ -n "$status" ]; then echo $status; exit 1; fi
+
+FROM base AS dev
+ENTRYPOINT ["bash"]

README.md

@@ -19,10 +19,13 @@ ___
   * [Workflow](#workflow)
   * [Run on new tag](#run-on-new-tag)
   * [Signing](#signing)
+  * [Upload artifacts](#upload-artifacts)
+  * [Install Only](#install-only)
 * [Customizing](#customizing)
   * [inputs](#inputs)
   * [environment variables](#environment-variables)
 * [Limitation](#limitation)
+* [Development](#development)
 * [License](#license)
 
 ## Usage
@@ -49,7 +52,7 @@ jobs:
         name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.14
+          go-version: 1.15
       -
         name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v2
@@ -97,10 +100,10 @@ If [signing is enabled](https://goreleaser.com/customization/#Signing) in your G
       -
         name: Import GPG key
         id: import_gpg
-        uses: crazy-max/ghaction-import-gpg@v2
+        uses: crazy-max/ghaction-import-gpg@v3
-        env:
+        with:
-          GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
+          gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
-          PASSPHRASE: ${{ secrets.PASSPHRASE }}
+          passphrase: ${{ secrets.PASSPHRASE }}
       -
         name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v2
@@ -120,6 +123,42 @@ signs:
     args: ["--batch", "-u", "{{ .Env.GPG_FINGERPRINT }}", "--output", "${signature}", "--detach-sign", "${artifact}"]
 ```
 
+### Upload artifacts
+
+For some events like pull request or schedule you might want to store the artifacts somewhere for testing
+purpose. You can do that with the [actions/upload-artifact](https://github.com/actions/upload-artifact) action:
+
+```yaml
+      -
+        name: Run GoReleaser
+        uses: goreleaser/goreleaser-action@v2
+        with:
+          version: latest
+          args: release --rm-dist
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      -
+        name: Upload assets
+        uses: actions/upload-artifact@v2
+        with:
+          name: myapp
+          path: dist/*
+```
+
+### Install Only
+
+```yaml
+steps:
+  -
+    name: Install GoReleaser
+    uses: goreleaser/goreleaser-action@v2
+    with:
+      install-only: true
+  -
+    name: Show GoReleaser version
+    run: goreleaser -v
+```
+
 ## Customizing
 
 ### inputs
@@ -131,6 +170,7 @@ Following inputs can be used as `step.with` keys
 | `version`**¹**   | String  | `latest`  | GoReleaser version                        |
 | `args`           | String  |           | Arguments to pass to GoReleaser           |
 | `workdir`        | String  | `.`       | Working directory (below repository root) |
+| `install-only`   | Bool    | `false`   | Just install GoReleaser                   |
 
 > **¹** Can be a fixed version like `v0.117.0` or a max satisfying semver one like `~> 0.132`. In this case this will return `v0.132.1`.
 
@@ -162,6 +202,19 @@ secret named `GH_PAT`, the step will look like this:
           GITHUB_TOKEN: ${{ secrets.GH_PAT }}
 ```
 
+## Development
+
+```
+# format code and build javascript artifacts
+docker buildx bake pre-checkin
+
+# validate all code has correctly formatted and built
+docker buildx bake validate
+
+# run tests
+docker buildx bake test
+```
+
 ## License
 
 MIT. See `LICENSE` for more details.

__tests__/git.test.ts

@@ -1,15 +1,30 @@
 import * as git from '../src/git';
 
 describe('git', () => {
-  it('returns git tag', async () => {
+  it('returns git tag through describe', async () => {
+    process.env.GITHUB_SHA = '309312125ed7a32fcd48f3a1e24dcafe669c186a';
     const tag: string = await git.getTag();
+    console.log(`tag: ${tag}`);
     expect(tag).not.toEqual('');
   });
+  it('returns git tag through GITHUB_SHA', async () => {
+    process.env.GITHUB_SHA = '6e37040623d14330555c7be1603a9182cf92d32a';
+    const tag: string = await git.getTag();
+    console.log(`tag: ${tag}`);
+    expect(tag).toEqual('v1');
+  });
+  it('returns git tag through GITHUB_REF', async () => {
+    process.env.GITHUB_REF = 'refs/tags/v2.2.1';
+    const tag: string = await git.getTag();
+    console.log(`tag: ${tag}`);
+    expect(tag).toEqual('v2.2.1');
+  });
   it('checks if tag is dirty', async () => {
     expect(await git.isTagDirty('v1.3.1')).toBe(true);
   });
   it('returns short commit', async () => {
     const commit: string = await git.getShortCommit();
+    console.log(`commit: ${commit}`);
     expect(commit).not.toEqual('');
   });
 });

__tests__/github.test.ts

@@ -5,6 +5,7 @@ describe('github', () => {
     const release = await github.getRelease('latest');
     expect(release).not.toBeNull();
     expect(release?.tag_name).not.toEqual('');
+    console.log(`tag_name: ${release?.tag_name}`);
   });
   it('returns v0.117.0 GoReleaser GitHub release', async () => {
     const release = await github.getRelease('v0.117.0');

action.yml

@@ -13,11 +13,15 @@ inputs:
     required: false
   args:
     description: 'Arguments to pass to GoReleaser'
-    required: true
+    required: false
   workdir:
     description: 'Working directory (below repository root)'
     default: '.'
     required: false
+  install-only:
+    description: 'Just install GoReleaser'
+    default: 'false'
+    required: false
 
 runs:
   using: 'node12'

docker-bake.hcl

@@ -0,0 +1,53 @@
+group "default" {
+  targets = ["build"]
+}
+
+group "pre-checkin" {
+  targets = ["update-yarn", "format", "build"]
+}
+
+group "validate" {
+  targets = ["validate-format", "validate-build", "validate-yarn"]
+}
+
+target "dockerfile" {
+  dockerfile = "Dockerfile.dev"
+}
+
+target "update-yarn" {
+  inherits = ["dockerfile"]
+  target = "update-yarn"
+  output = ["."]
+}
+
+target "build" {
+  inherits = ["dockerfile"]
+  target = "dist"
+  output = ["."]
+}
+
+target "test" {
+  inherits = ["dockerfile"]
+  target = "test"
+}
+
+target "format" {
+  inherits = ["dockerfile"]
+  target = "format"
+  output = ["."]
+}
+
+target "validate-format" {
+  inherits = ["dockerfile"]
+  target = "validate-format"
+}
+
+target "validate-build" {
+  inherits = ["dockerfile"]
+  target = "validate-build"
+}
+
+target "validate-yarn" {
+  inherits = ["dockerfile"]
+  target = "validate-yarn"
+}

go.mod

@@ -1,3 +1,3 @@
 module github.com/goreleaser/goreleaser-action
 
-go 1.14
+go 1.15

package.json

@@ -21,23 +21,23 @@
   "author": "CrazyMax",
   "license": "MIT",
   "dependencies": {
-    "@actions/core": "^1.2.4",
+    "@actions/core": "^1.2.6",
     "@actions/exec": "^1.0.4",
-    "@actions/http-client": "^1.0.8",
+    "@actions/http-client": "^1.0.9",
-    "@actions/tool-cache": "^1.5.5"
+    "@actions/tool-cache": "^1.6.1"
   },
   "devDependencies": {
-    "@types/jest": "^26.0.0",
+    "@types/jest": "^26.0.14",
-    "@types/node": "^14.0.13",
+    "@types/node": "^14.11.2",
-    "@zeit/ncc": "^0.22.3",
+    "@vercel/ncc": "^0.24.1",
     "dotenv": "^8.2.0",
-    "jest": "^26.0.1",
+    "jest": "^26.4.2",
-    "jest-circus": "^26.0.1",
+    "jest-circus": "^26.4.2",
-    "jest-runtime": "^26.0.1",
+    "jest-runtime": "^26.4.2",
-    "prettier": "^2.0.5",
+    "prettier": "^2.1.2",
     "tmp": "^0.2.1",
-    "ts-jest": "^26.1.0",
+    "ts-jest": "^26.4.1",
-    "typescript": "^3.9.5",
+    "typescript": "^4.0.3",
     "typescript-formatter": "^7.2.2"
   }
 }

src/git.ts

@@ -11,7 +11,20 @@ const git = async (args: string[] = []): Promise<string> => {
 
 export async function getTag(): Promise<string> {
   try {
-    return await git(['describe', '--tags', '--abbrev=0']);
+    if ((process.env.GITHUB_REF || '').startsWith('refs/tags')) {
+      const tag = (process.env.GITHUB_REF || '').split('/').pop();
+      if (tag !== '' && tag !== undefined) {
+        return tag;
+      }
+    }
+    return await git(['tag', '--points-at', `${process.env.GITHUB_SHA}`, '--sort', '-version:creatordate']).then(
+      tags => {
+        if (tags.length == 0) {
+          return git(['describe', '--tags', '--abbrev=0']);
+        }
+        return tags.split('\n')[0];
+      }
+    );
   } catch (err) {
     return '';
   }

src/main.ts

@@ -2,23 +2,35 @@ import * as git from './git';
 import * as installer from './installer';
 import * as core from '@actions/core';
 import * as exec from '@actions/exec';
+import {dirname} from 'path';
 
 async function run(): Promise<void> {
   try {
     const version = core.getInput('version') || 'latest';
-    const args = core.getInput('args', {required: true});
+    const args = core.getInput('args');
     const workdir = core.getInput('workdir') || '.';
+    const isInstallOnly = /^true$/i.test(core.getInput('install-only'));
     const goreleaser = await installer.getGoReleaser(version);
+    core.info(`✅ GoReleaser installed successfully`);
 
-    const commit = await git.getShortCommit();
+    if (isInstallOnly) {
-    const tag = await git.getTag();
+      const goreleaserDir = dirname(goreleaser);
-    const isTagDirty = await git.isTagDirty(tag);
+      core.addPath(goreleaserDir);
+      core.debug(`Added ${goreleaserDir} to PATH`);
+      return;
+    } else if (!args) {
+      throw new Error('args input required');
+    }
 
     if (workdir && workdir !== '.') {
       core.info(`📂 Using ${workdir} as working directory...`);
       process.chdir(workdir);
     }
 
+    const commit = await git.getShortCommit();
+    const tag = await git.getTag();
+    const isTagDirty = await git.isTagDirty(tag);
+
     let snapshot = '';
     if (args.split(' ').indexOf('release') > -1) {
       if (isTagDirty) {
@@ -32,6 +44,9 @@ async function run(): Promise<void> {
     }
 
     core.info('🏃 Running GoReleaser...');
+    if (!('GORELEASER_CURRENT_TAG' in process.env)) {
+      process.env.GORELEASER_CURRENT_TAG = tag;
+    }
     await exec.exec(`${goreleaser} ${args}${snapshot}`);
   } catch (error) {
     core.setFailed(error.message);

tsconfig.json

@@ -3,7 +3,8 @@
     "target": "es6",
     "module": "commonjs",
     "lib": [
-      "es6"
+      "es6",
+      "dom"
     ],
     "newLine": "lf",
     "outDir": "./lib",