fix: don't depend on the GitHub API to check release (#391)

* fix: don't depend on the GitHub API to check release

* chore: update generated content

---------

Co-authored-by: CrazyMax <crazy-max@users.noreply.github.com>

.github/workflows/ci.yml

@@ -3,6 +3,7 @@ name: ci
 on:
   schedule:
     - cron: '0 10 * * *' # everyday at 10am
+  workflow_dispatch:
   push:
     branches:
       - 'master'

.github/workflows/test.yml

@@ -6,9 +6,6 @@ on:
       - 'master'
       - 'releases/v*'
   pull_request:
-    branches:
-      - 'master'
-      - 'releases/v*'
 
 jobs:
   test:

README.md

@@ -5,7 +5,7 @@
   <p align="center">
     <a href="https://github.com/goreleaser/goreleaser-action/releases/latest"><img alt="GitHub release" src="https://img.shields.io/github/release/goreleaser/goreleaser-action.svg?logo=github&style=flat-square"></a>
     <a href="https://github.com/marketplace/actions/goreleaser-action"><img alt="GitHub marketplace" src="https://img.shields.io/badge/marketplace-goreleaser--action-blue?logo=github&style=flat-square"></a>
-    <a href="https://github.com/goreleaser/goreleaser-action/actions?workflow=test"><img alt="Test workflow" src="https://img.shields.io/github/workflow/status/goreleaser/goreleaser-action/test?label=test&logo=github&style=flat-square"></a>
+    <a href="https://github.com/goreleaser/goreleaser-action/actions?workflow=test"><img alt="Test workflow" src="https://img.shields.io/github/actions/workflow/status/goreleaser/goreleaser-action/test.yml?label=test&branch=master&logo=github&style=flat-square"></a>
     <a href="https://codecov.io/gh/goreleaser/goreleaser-action"><img alt="Codecov" src="https://img.shields.io/codecov/c/github/goreleaser/goreleaser-action?logo=codecov&style=flat-square"></a>
   </p>
 </p>
@@ -53,7 +53,7 @@ jobs:
         uses: actions/setup-go@v3
       -
         name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v3
+        uses: goreleaser/goreleaser-action@v4
         with:
           # either 'goreleaser' (default) or 'goreleaser-pro'
           distribution: goreleaser
@@ -83,7 +83,7 @@ Or with a condition on GoReleaser step:
 ```yaml
       -
         name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v3
+        uses: goreleaser/goreleaser-action@v4
         if: startsWith(github.ref, 'refs/tags/')
         with:
           version: latest
@@ -109,7 +109,7 @@ the [Import GPG](https://github.com/crazy-max/ghaction-import-gpg) GitHub Action
           passphrase: ${{ secrets.PASSPHRASE }}
       -
         name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v3
+        uses: goreleaser/goreleaser-action@v4
         with:
           version: latest
           args: release --rm-dist
@@ -134,7 +134,7 @@ purpose. You can do that with the [actions/upload-artifact](https://github.com/a
 ```yaml
       -
         name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v3
+        uses: goreleaser/goreleaser-action@v4
         with:
           version: latest
           args: release --rm-dist
@@ -155,7 +155,7 @@ purpose. You can do that with the [actions/upload-artifact](https://github.com/a
 steps:
   -
     name: Install GoReleaser
-    uses: goreleaser/goreleaser-action@v3
+    uses: goreleaser/goreleaser-action@v4
     with:
       install-only: true
   -
@@ -183,17 +183,17 @@ Following inputs can be used as `step.with` keys
 
 Following outputs are available
 
-| Name              | Type    | Description                           |
-|-------------------|---------|---------------------------------------|
-| `artifacts`       | JSON    | Build result artifacts |
-| `metadata`        | JSON    | Build result metadata |
+| Name        | Type | Description            |
+|-------------|------|------------------------|
+| `artifacts` | JSON | Build result artifacts |
+| `metadata`  | JSON | Build result metadata  |
 
 ### environment variables
 
 Following environment variables can be used as `step.env` keys
 
-| Name             | Description                           |
-|------------------|---------------------------------------|
+| Name             | Description                                                                                                                                         |
+|------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------|
 | `GITHUB_TOKEN`   | [GITHUB_TOKEN](https://help.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token) as provided by `secrets` |
 | `GORELEASER_KEY` | Your [GoReleaser Pro](https://goreleaser.com/pro) License Key, in case you are using the `goreleaser-pro` distribution                              |
 
@@ -209,7 +209,7 @@ secret named `GH_PAT`, the step will look like this:
 ```yaml
       -
         name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v3
+        uses: goreleaser/goreleaser-action@v4
         with:
           version: latest
           args: release --rm-dist
@@ -217,6 +217,10 @@ secret named `GH_PAT`, the step will look like this:
           GITHUB_TOKEN: ${{ secrets.GH_PAT }}
 ```
 
+## Migrating from v3
+
+If you need the auto-snapshot feature, take a look at [this example repository](https://github.com/caarlos0/goreleaser-action-v4-auto-snapshot-example): it's a minimal working example with all you need.
+
 ## Development
 
 ```

__tests__/github.test.ts

@@ -1,7 +1,7 @@
 import {describe, expect, it} from '@jest/globals';
 import * as github from '../src/github';
 
-describe('github', () => {
+describe('getRelease', () => {
   it('returns latest GoReleaser GitHub release', async () => {
     const release = await github.getRelease('goreleaser', 'latest');
     expect(release).not.toBeNull();
@@ -20,21 +20,33 @@ describe('github', () => {
     expect(release?.tag_name).toEqual('v0.182.1');
   });
 
+  it('unknown GoReleaser release', async () => {
+    await expect(github.getRelease('goreleaser', 'foo')).rejects.toThrowError(
+      new Error('Cannot find GoReleaser release foo in https://goreleaser.com/static/releases.json')
+    );
+  });
+
   it('returns latest GoReleaser Pro GitHub release', async () => {
     const release = await github.getRelease('goreleaser-pro', 'latest');
     expect(release).not.toBeNull();
     expect(release?.tag_name).not.toEqual('');
   });
 
-  it('returns v0.182.0-pro GoReleaser Pro GitHub release', async () => {
-    const release = await github.getRelease('goreleaser-pro', 'v0.182.0-pro');
+  it('returns v0.182.0 GoReleaser Pro GitHub release', async () => {
+    const release = await github.getRelease('goreleaser-pro', 'v0.182.0');
     expect(release).not.toBeNull();
     expect(release?.tag_name).toEqual('v0.182.0-pro');
   });
 
-  it('returns v0.182.1-pro GoReleaser Pro GitHub release when using semver', async () => {
+  it('returns v0.182.1 GoReleaser Pro GitHub release', async () => {
     const release = await github.getRelease('goreleaser-pro', '~> 0.182');
     expect(release).not.toBeNull();
     expect(release?.tag_name).toEqual('v0.182.1-pro');
   });
+
+  it('unknown GoReleaser Pro release', async () => {
+    await expect(github.getRelease('goreleaser-pro', 'foo')).rejects.toThrowError(
+      new Error('Cannot find GoReleaser release foo-pro in https://goreleaser.com/static/releases-pro.json')
+    );
+  });
 });

dist/licenses.txt

@@ -236,6 +236,25 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 
 
+lru-cache
+ISC
+The ISC License
+
+Copyright (c) Isaac Z. Schlueter and Contributors
+
+Permission to use, copy, modify, and/or distribute this software for any
+purpose with or without fee is hereby granted, provided that the above
+copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
+IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+
+
 require-directory
 MIT
 The MIT License (MIT)
@@ -375,6 +394,25 @@ TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
 THIS SOFTWARE.
 
 
+yallist
+ISC
+The ISC License
+
+Copyright (c) Isaac Z. Schlueter and Contributors
+
+Permission to use, copy, modify, and/or distribute this software for any
+purpose with or without fee is hereby granted, provided that the above
+copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
+IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+
+
 yargs
 MIT
 MIT License

package.json

@@ -26,6 +26,7 @@
     "@actions/http-client": "^2.0.1",
     "@actions/tool-cache": "^2.0.1",
     "js-yaml": "^4.1.0",
+    "semver": "^7.3.8",
     "yargs": "^17.6.2"
   },
   "devDependencies": {

src/context.ts

@@ -15,7 +15,7 @@ export interface Inputs {
 export async function getInputs(): Promise<Inputs> {
   return {
     distribution: core.getInput('distribution') || 'goreleaser',
-    version: core.getInput('version'),
+    version: core.getInput('version') || 'latest',
     args: core.getInput('args'),
     workdir: core.getInput('workdir') || '.',
     installOnly: core.getBooleanInput('install-only')

src/github.ts

@@ -4,28 +4,57 @@ import * as core from '@actions/core';
 import * as httpm from '@actions/http-client';
 
 export interface GitHubRelease {
-  id: number;
   tag_name: string;
 }
 
-export const getRelease = async (distribution: string, version: string): Promise<GitHubRelease | null> => {
-  const resolvedVersion: string = (await resolveVersion(distribution, version)) || version;
-  const url = `https://github.com/goreleaser/${distribution}/releases/${resolvedVersion}`;
+export const getRelease = async (distribution: string, version: string): Promise<GitHubRelease> => {
+  if (version === 'latest') {
+    return getLatestRelease(distribution);
+  }
+  return getReleaseTag(distribution, version);
+};
+
+export const getReleaseTag = async (distribution: string, version: string): Promise<GitHubRelease> => {
+  const tag: string = (await resolveVersion(distribution, version)) || version;
+  const suffix: string = goreleaser.distribSuffix(distribution);
+  const url = `https://goreleaser.com/static/releases${suffix}.json`;
   const http: httpm.HttpClient = new httpm.HttpClient('goreleaser-action');
-  return (await http.getJson<GitHubRelease>(url)).result;
+  const resp: httpm.HttpClientResponse = await http.get(url);
+  const body = await resp.readBody();
+  const statusCode = resp.message.statusCode || 500;
+  if (statusCode >= 400) {
+    throw new Error(
+      `Failed to get GoReleaser release ${version}${suffix} from ${url} with status code ${statusCode}: ${body}`
+    );
+  }
+  const releases = <Array<GitHubRelease>>JSON.parse(body);
+  const res = releases.filter(r => r.tag_name === tag).shift();
+  if (res) {
+    return res;
+  }
+  throw new Error(`Cannot find GoReleaser release ${version}${suffix} in ${url}`);
+};
+
+export const getLatestRelease = async (distribution: string): Promise<GitHubRelease> => {
+  const suffix: string = goreleaser.distribSuffix(distribution);
+  const url = `https://goreleaser.com/static/latest${suffix}`;
+  const http: httpm.HttpClient = new httpm.HttpClient('goreleaser-action');
+  const resp: httpm.HttpClientResponse = await http.get(url);
+  const body = await resp.readBody();
+  const statusCode = resp.message.statusCode || 500;
+  if (statusCode >= 400) {
+    throw new Error(`Failed to get GoReleaser release latest from ${url} with status code ${statusCode}: ${body}`);
+  }
+  return {tag_name: body};
 };
 
 const resolveVersion = async (distribution: string, version: string): Promise<string | null> => {
   const allTags: Array<string> | null = await getAllTags(distribution);
   if (!allTags) {
-    throw new Error(`Cannot find GoReleaser tags`);
+    throw new Error(`Cannot download ${distribution} tags`);
   }
   core.debug(`Found ${allTags.length} tags in total`);
 
-  if (version === 'latest' || !goreleaser.isPro(distribution)) {
-    return semver.maxSatisfying(allTags, version);
-  }
-
   const cleanTags: Array<string> = allTags.map(tag => cleanTag(tag));
   const cleanVersion: string = cleanTag(version);
   return semver.maxSatisfying(cleanTags, cleanVersion) + goreleaser.distribSuffix(distribution);
@@ -39,6 +68,7 @@ const getAllTags = async (distribution: string): Promise<Array<string>> => {
   const http: httpm.HttpClient = new httpm.HttpClient('goreleaser-action');
   const suffix: string = goreleaser.distribSuffix(distribution);
   const url = `https://goreleaser.com/static/releases${suffix}.json`;
+  core.debug(`Downloading ${url}`);
   const getTags = http.getJson<Array<GitHubTag>>(url);
   return getTags.then(response => {
     if (response.result == null) {

src/goreleaser.ts

@@ -8,11 +8,7 @@ import * as core from '@actions/core';
 import * as tc from '@actions/tool-cache';
 
 export async function install(distribution: string, version: string): Promise<string> {
-  const release: github.GitHubRelease | null = await github.getRelease(distribution, version);
-  if (!release) {
-    throw new Error(`Cannot find GoReleaser ${version} release`);
-  }
-
+  const release: github.GitHubRelease = await github.getRelease(distribution, version);
   const filename = getFilename(distribution);
   const downloadUrl = util.format(
     'https://github.com/goreleaser/%s/releases/download/%s/%s',

test/.goreleaser-signing.yml

@@ -14,14 +14,11 @@ builds:
       - linux
       - windows
     goarch:
-      - 386
-      - amd64
+      - "386"
+      - "amd64"
 
 archives:
   -
-    replacements:
-      386: i386
-      amd64: x86_64
     format_overrides:
       - goos: windows
         format: zip

test/.goreleaser.yml

@@ -14,14 +14,11 @@ builds:
       - linux
       - windows
     goarch:
-      - 386
-      - amd64
+      - "386"
+      - "amd64"
 
 archives:
   -
-    replacements:
-      386: i386
-      amd64: x86_64
     format_overrides:
       - goos: windows
         format: zip

yarn.lock

@@ -2630,17 +2630,10 @@ json-stable-stringify-without-jsonify@^1.0.1:
   resolved "https://registry.yarnpkg.com/json-stable-stringify-without-jsonify/-/json-stable-stringify-without-jsonify-1.0.1.tgz#9db7b59496ad3f3cfef30a75142d2d930ad72651"
   integrity sha1-nbe1lJatPzz+8wp1FC0tkwrXJlE=
 
-json5@2.x, json5@^2.1.2:
-  version "2.2.0"
-  resolved "https://registry.yarnpkg.com/json5/-/json5-2.2.0.tgz#2dfefe720c6ba525d9ebd909950f0515316c89a3"
-  integrity sha512-f+8cldu7X/y7RAJurMEJmdoKXGB/X550w2Nr3tTbezL6RwEE/iMcm+tZnXeoZtKuOq6ft8+CqzEkrIgx1fPoQA==
-  dependencies:
-    minimist "^1.2.5"
-
-json5@^2.2.1:
-  version "2.2.1"
-  resolved "https://registry.yarnpkg.com/json5/-/json5-2.2.1.tgz#655d50ed1e6f95ad1a3caababd2b0efda10b395c"
-  integrity sha512-1hqLFMSrGHRHxav9q9gNjJ5EXznIxGVO09xQRrwplcS8qs28pZ8s8hupZAmqDwZUmVZ2Qb2jnyPOWcDH8m8dlA==
+json5@2.x, json5@^2.1.2, json5@^2.2.1:
+  version "2.2.3"
+  resolved "https://registry.yarnpkg.com/json5/-/json5-2.2.3.tgz#78cd6f1a19bdc12b73db5ad0c61efd66c1e29283"
+  integrity sha512-XmOWe7eyHYH14cLdVPoyg+GOH3rYX++KpzrylJwSW98t3Nk+U8XOl8FWKOgwtzdb8lXGf6zYwDUzeHMWfxasyg==
 
 kleur@^3.0.3:
   version "3.0.3"
@@ -2763,11 +2756,6 @@ minimatch@^3.0.4:
   dependencies:
     brace-expansion "^1.1.7"
 
-minimist@^1.2.5:
-  version "1.2.6"
-  resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.6.tgz#8637a5b759ea0d6e98702cfb3a9283323c93af44"
-  integrity sha512-Jsjnk4bw3YJqYzbdyBiNsPWHPfO++UGG749Cxs6peCu5Xg4nrena6OVxOYxrQTqww0Jmwt+Ref8rggumkTLz9Q==
-
 ms@2.1.2:
   version "2.1.2"
   resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.2.tgz#d09d1f357b443f493382a8eb3ccd183872ae6009"
@@ -2813,7 +2801,7 @@ nwsapi@^2.2.0:
 once@^1.3.0:
   version "1.4.0"
   resolved "https://registry.yarnpkg.com/once/-/once-1.4.0.tgz#583b1aa775961d4b113ac17d9c50baef9dd76bd1"
-  integrity sha1-WDsap3WWHUsROsF9nFC6753Xa9E=
+  integrity sha512-lNaJgI+2Q5URQBkccEKHTQOPaXdUxnZZElQTZY0MFUAuaEqe1E+Nyvgdz/aIyNi6Z9MzO5dv1H8n58/GELp3+w==
   dependencies:
     wrappy "1"
 
@@ -3089,6 +3077,13 @@ semver@^6.0.0, semver@^6.1.0, semver@^6.3.0:
   resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.0.tgz#ee0a64c8af5e8ceea67687b133761e1becbd1d3d"
   integrity sha512-b39TBaTSfV6yBrapU89p5fKekE2m/NwnDocOVruQFS1/veMgdzuPcnOM34M6CwxW8jH/lxEa5rBoDeUwu5HHTw==
 
+semver@^7.3.8:
+  version "7.3.8"
+  resolved "https://registry.yarnpkg.com/semver/-/semver-7.3.8.tgz#07a78feafb3f7b32347d725e33de7e2a2df67798"
+  integrity sha512-NB1ctGL5rlHrPJtFDVIVzTyQylMLu9N9VICA6HSFJo8MCGVTMW6gfpicwKmmK/dAjTOrqu5l63JJOpDSrAis3A==
+  dependencies:
+    lru-cache "^6.0.0"
+
 shebang-command@^2.0.0:
   version "2.0.0"
   resolved "https://registry.yarnpkg.com/shebang-command/-/shebang-command-2.0.0.tgz#ccd0af4f8835fbdc265b82461aaf0c36663f34ea"